Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#589841 [sitecore-jss-nextjs] use token in redirects. fixed bug #1559

Merged
merged 4 commits into from
Jul 13, 2023
Merged

#589841 [sitecore-jss-nextjs] use token in redirects. fixed bug #1559

merged 4 commits into from
Jul 13, 2023

Conversation

matkovskyi
Copy link
Collaborator

@matkovskyi matkovskyi commented Jul 13, 2023 •
edited
Loading

Description / Motivation

There was problem with regexp. Fixed and remove smell code

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@matkovskyi matkovskyi force-pushed the bugfix/589841-use-token-in-redirects branch from c0d20b1 to 22c347a Compare July 13, 2023 13:25
illiakovalenko
illiakovalenko approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any unit tests to be updated?

@illiakovalenko illiakovalenko merged commit e191b95 into dev Jul 13, 2023
1 check passed
@illiakovalenko illiakovalenko deleted the bugfix/589841-use-token-in-redirects branch July 13, 2023 13:41
art-alexeyenko pushed a commit that referenced this pull request Jul 18, 2023
@matkovskyi @art-alexeyenko
[sitecore-jss-nextjs] use token in redirects. fixed bug (#1559)
a20341d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matkovskyi @illiakovalenko