Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#530504: [middleware-redirects] fixed redirects with query string #1449

Merged
merged 1 commit into from
Apr 26, 2023
Merged

#530504: [middleware-redirects] fixed redirects with query string #1449

merged 1 commit into from
Apr 26, 2023

Conversation

matkovskyi
Copy link
Collaborator

@matkovskyi matkovskyi commented Apr 25, 2023 •
edited
Loading

Description / Motivation

The redirects didn't work with query string

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@matkovskyi matkovskyi force-pushed the bugfix/530504-fixed-redirects-with-qs branch from e053f8e to 09d9469 Compare April 25, 2023 10:33
@matkovskyi matkovskyi force-pushed the bugfix/530504-fixed-redirects-with-qs branch from 09d9469 to 44160f7 Compare April 25, 2023 12:05
ambrauer
ambrauer reviewed Apr 25, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matkovskyi Please check unit tests (currently failing) and add new test(s) to cover query string use-case.

@matkovskyi matkovskyi force-pushed the bugfix/530504-fixed-redirects-with-qs branch from 44160f7 to abcb31d Compare April 26, 2023 10:28
@matkovskyi matkovskyi force-pushed the bugfix/530504-fixed-redirects-with-qs branch from abcb31d to 279d3a4 Compare April 26, 2023 10:31
@matkovskyi
Copy link
Collaborator Author

@matkovskyi Please check unit tests (currently failing) and add new test(s) to cover query string use-case.

Fixed and added a new unit test

illiakovalenko
illiakovalenko approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍
Let's wait for @ambrauer review

ambrauer
ambrauer approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@ambrauer ambrauer merged commit 67625e2 into dev Apr 26, 2023
@ambrauer ambrauer deleted the bugfix/530504-fixed-redirects-with-qs branch April 26, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matkovskyi @ambrauer @illiakovalenko