Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-nextjs] [Personalize] Don't resolve site in middleware when personalization is not enabled #1360

Merged
merged 1 commit into from
Mar 2, 2023
Merged

[sitecore-jss-nextjs] [Personalize] Don't resolve site in middleware when personalization is not enabled #1360

merged 1 commit into from
Mar 2, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Mar 2, 2023 •
edited
Loading

Description / Motivation

Resolve site only in case personalization is enabled, otherwise in preview mode newly added site can't be resolved

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team March 2, 2023 12:57
@illiakovalenko illiakovalenko changed the title [sitecore-jss-nextjs] [Personalize] Don't resolve site when preview mode is enabled [sitecore-jss-nextjs] [Personalize] Don't resolve site when personalization is not enabled Mar 2, 2023
@illiakovalenko illiakovalenko changed the title [sitecore-jss-nextjs] [Personalize] Don't resolve site when personalization is not enabled [sitecore-jss-nextjs] [Personalize] Don't resolve site in middleware when personalization is not enabled Mar 2, 2023
sc-addypathania
sc-addypathania approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@sc-addypathania sc-addypathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@ambrauer ambrauer merged commit ff4c891 into dev Mar 2, 2023
@ambrauer ambrauer deleted the bugfix/575762 branch March 2, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc-addypathania sc-addypathania sc-addypathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@illiakovalenko @sc-addypathania @ambrauer