Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nextjs] Add rewrite for Sitecore's default 404 prefix #1345

Merged
merged 2 commits into from
Feb 17, 2023
Merged

[nextjs] Add rewrite for Sitecore's default 404 prefix #1345

merged 2 commits into from
Feb 17, 2023

Conversation

art-alexeyenko
Copy link
Contributor

Adds an extra rewrite rule that allows JSS to handle Sitecore's default not-found page correctly.

Testing Details

Manual testing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team February 16, 2023 20:05
@art-alexeyenko art-alexeyenko merged commit 045efbf into dev Feb 17, 2023
@art-alexeyenko art-alexeyenko deleted the bug/next-service-endpoint-rewrite branch February 17, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer left review comments

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@art-alexeyenko @ambrauer @illiakovalenko