Multisite SSG should always include site prefix #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrauer
requested changes
Feb 15, 2023
...ss/src/templates/nextjs-multisite/src/lib/sitemap-fetcher/plugins/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
...ss/src/templates/nextjs-multisite/src/lib/sitemap-fetcher/plugins/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
...sitecore-jss/src/templates/nextjs/src/lib/sitemap-fetcher/plugins/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
ambrauer
requested changes
Feb 16, 2023
...ss/src/templates/nextjs-multisite/src/lib/sitemap-fetcher/plugins/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/services/mutisite-graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/services/mutisite-graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
ambrauer
requested changes
Feb 21, 2023
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures GraphQLSitemapService will return paths with site prefix applied even if one site is provided in array during class initialization. This, in combination with previous multisite changes, leads to some changes in the class' behavior:
nextjs and nextjs-multisite templates were updated to accommodate the change.
Testing Details
Manual testing with extra unit tests.
Types of changes