Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Angular] The data "This page does not exist" is displayed during loading the page of angular app in EE #1331

Merged
merged 1 commit into from
Feb 8, 2023
Merged

[Angular] The data "This page does not exist" is displayed during loading the page of angular app in EE #1331

merged 1 commit into from
Feb 8, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Feb 8, 2023 •
edited
Loading

Description / Motivation

  • Prevent refreshing of the browser on page load in the experience editor.

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team February 8, 2023 09:55
@illiakovalenko illiakovalenko changed the title [Angular][EE] The data "This page does not exist" is displayed during loading the page of angular app in EE [Angular] The data "This page does not exist" is displayed during loading the page of angular app in EE Feb 8, 2023
ambrauer
ambrauer approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand why this was added in the first place, but change looks good to me.

@ambrauer ambrauer merged commit 4d85b85 into dev Feb 8, 2023
@ambrauer ambrauer deleted the bugfix/463527 branch February 8, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@illiakovalenko @ambrauer