Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next.js] Finalize @sitecore/engage version upgrade #1317

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Jan 31, 2023

The engage version has been updated as part of nextjs third party upgrades.
This PR only renames pos param to pointOfSale in pageView call from CdpPageView control to match updated call signature.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team January 31, 2023 18:13
@illiakovalenko illiakovalenko changed the title [nexjts] Finalize @sitecore/engage version upgrade [Next.js] Finalize @sitecore/engage version upgrade Jan 31, 2023
@illiakovalenko illiakovalenko merged commit 5a4f0e1 into dev Jan 31, 2023
@illiakovalenko illiakovalenko deleted the feature/engage-nextjs-upgrade branch January 31, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants