Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next.js][Multi-site] Added default for graphQLEndpoint config prop #1302

Merged
merged 1 commit into from
Jan 24, 2023
Merged

[Next.js][Multi-site] Added default for graphQLEndpoint config prop #1302

merged 1 commit into from
Jan 24, 2023

Conversation

ambrauer
Copy link
Contributor

Description / Motivation

This is a follow-up to #1296, adding the same default (pulling from env var) for graphQLEndpoint config prop.

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

art-alexeyenko
art-alexeyenko approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, all good. Thanks for the follow up - I missed that prop.

@ambrauer ambrauer merged commit 94ad602 into dev Jan 24, 2023
@ambrauer ambrauer deleted the fix/569034 branch January 24, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ambrauer @art-alexeyenko