Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional test coverage for create-sitecore-jss #1260

Merged
merged 6 commits into from
Dec 16, 2022
Merged

Additional test coverage for create-sitecore-jss #1260

merged 6 commits into from
Dec 16, 2022

Conversation

ambrauer
Copy link
Contributor

Description / Motivation

  • Provides additional test coverage for create-sitecore-jss package
  • nyc exclusions adjusted to better reflect coverage
  • Refactored root index.ts (to bin.ts) to enable testing
  • Other minor adjustments for testability

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ambrauer ambrauer requested a review from a team December 15, 2022 20:06
illiakovalenko
illiakovalenko approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very nice! Good job!

@illiakovalenko illiakovalenko merged commit d1f9674 into dev Dec 16, 2022
@illiakovalenko illiakovalenko deleted the feature/563415-create-sitecore-jss-tests branch December 16, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ambrauer @illiakovalenko