Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#553209: [NextJS] added fix for load default export component #1245

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

matkovskyi
Copy link
Collaborator

@matkovskyi matkovskyi commented Nov 18, 2022

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@matkovskyi matkovskyi changed the title #553209: added fix for load default export component #553209: [nextjs] added fix for load default export component Nov 18, 2022
@matkovskyi matkovskyi changed the title #553209: [nextjs] added fix for load default export component #553209: [NextJs] added fix for load default export component Nov 18, 2022
@matkovskyi matkovskyi changed the title #553209: [NextJs] added fix for load default export component #553209: [NextJS] added fix for load default export component Nov 18, 2022
@illiakovalenko
Copy link
Contributor

@matkovskyi What is the use case? Why Default can be provided here? Variant name?

@matkovskyi matkovskyi force-pushed the bugfix/553209-error-component-missing branch from 6a2fa63 to 63ecabb Compare November 22, 2022 08:44
@matkovskyi
Copy link
Collaborator Author

@matkovskyi What is the use case? Why Default can be provided here? Variant name?

Yes, it's variant name. Just there is using 'Default' like default variant, but in the components I saw two types of variant define default component, these:

export default
or
export const Default

So that's why I added a little fix for this factory

@illiakovalenko illiakovalenko merged commit e6fb46c into dev Nov 22, 2022
@illiakovalenko illiakovalenko deleted the bugfix/553209-error-component-missing branch November 22, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants