[Next.js][Editing] Partial rendering implementation #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e view events (#1166) * use consistent cookie prefix casing * Use a domain instead of full URL for cdp-cdp-service (consistent with SitecoreCloud Engage SDK) * switchover to new engage SDK * avoid multiple tracking requests * Send (properly formatted) pageVariantId in page view event * emphasize cookie consent management implementation for disabled (matches language in CdpIntegrationScript) * Moved getContentId to CdpHelper (for centralized id formatting logic) * bump @sitecore/engage to 0.3.0 * Revert "Use a domain instead of full URL for cdp-cdp-service (consistent with SitecoreCloud Engage SDK)" This reverts commit 14147c6. * Additional fixes and tests added * renamed "CdpIntegrationScript" > "CdpPageView"
… feature/551067-21.0.0
ambrauer
reviewed
Sep 27, 2022
packages/create-sitecore-jss/src/templates/nextjs/src/EditingComponentPlaceholder.tsx
Outdated
Show resolved
Hide resolved
ambrauer
suggested changes
Sep 27, 2022
ambrauer
approved these changes
Oct 4, 2022
packages/sitecore-jss-nextjs/src/components/EditingComponentPlaceholder.tsx
Show resolved
Hide resolved
… feature/551067-21.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
We need to support rendering of a single component for editing purposes. This will be used by Pages (no plans for EE to use). It utilizes the same /api/editing/render endpoint and middleware
Testing Details
Types of changes