Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Angular] Extend richText directive to render internal routerlinks #1050

Merged
merged 6 commits into from
Jun 3, 2022
Merged

[Angular] Extend richText directive to render internal routerlinks #1050

merged 6 commits into from
Jun 3, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jun 2, 2022 •
edited
Loading

Description / Motivation

  • Extend existing richText directive to render internal links using routerLink
  • Merge linkfield classes instead of replacement

Covers #375

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko changed the title Extend richText directive to render internal routerlinks [Angular] Extend richText directive to render internal routerlinks Jun 2, 2022
@illiakovalenko illiakovalenko requested a review from a team June 2, 2022 13:33
ambrauer
ambrauer approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good! Just one suggestion.

packages/sitecore-jss/src/utils/resolve-url.ts Show resolved Hide resolved
@illiakovalenko illiakovalenko merged commit 27db6b3 into dev Jun 3, 2022
@illiakovalenko illiakovalenko deleted the feature/534719 branch June 3, 2022 13:22
This was referenced Jun 23, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@illiakovalenko @ambrauer