Feature/graphql nextjs sitemap update #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base GQL service to use with site and search services ("DI-ing" graphql services in sitecore-jss)
ambrauer
requested changes
Apr 29, 2022
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.test.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.test.ts
Outdated
Show resolved
Hide resolved
ambrauer
reviewed
May 3, 2022
packages/sitecore-jss-nextjs/src/services/graphql-sitemap-service.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nextjs Sitemap service rework to use 'site' query instead of 'search'
Description / Motivation
The fresh 'site' query from edge GQL schema allows for a more intuitive sitemap generation along with built in filtering by includedPaths and excludedPaths.
Testing Details
One extra unit test added for includedPaths and excludedPaths variables in a query.
Types of changes
Updated GraphQLSitemapService will only work with Sitecore versions that have 'site' query present in edge schema.