chore(checkstyle): add check for internal imports (INRIA#3244)

SirYwell · Feb 14, 2020 · 12543fe · 12543fe
1 parent 4ee28da
commit 12543fe
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/checkstyle.xml b/checkstyle.xml
@@ -28,6 +28,14 @@
     <module name="AvoidStarImport"/>
     <module name="IllegalImport"/> <!-- defaults to sun.* packages -->
     <module name="RedundantImport"/>
+    <module name="IllegalImport">
+      <property name="regexp" value="true" />
+      <property name="illegalClasses" value="^(?!.*(spoon|jdt)).*internal.*$" />
+      <!--The regex looks for imports containing internal and not containing spoon or jdt. Some examples are:
+      import spoon.pattern.internal.node.ForEachNode; // allowed because internal package but from spoon.
+      import org.eclipse.jdt.internal.compiler.batch.CompilationUnit; //allowed because internal package but from jdt.
+      import org.apache.commons.jexl2.internal.introspection; //rejected because import of internal package -->
+    </module>
     <module name="UnusedImports">
       <property name="processJavadoc" value="true"/>
     </module>

diff --git a/pom.xml b/pom.xml
@@ -194,7 +194,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
-        <version>3.0.0</version>
+        <version>3.1.0</version>
         <configuration>
           <failsOnError>true</failsOnError>
           <configLocation>checkstyle.xml</configLocation>

diff --git a/spoon-control-flow/pom.xml b/spoon-control-flow/pom.xml
@@ -37,7 +37,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
-                <version>3.0.0</version>
+                <version>3.1.0</version>
                 <configuration>
                     <failsOnError>true</failsOnError>
                     <configLocation>../checkstyle.xml</configLocation>

diff --git a/spoon-decompiler/pom.xml b/spoon-decompiler/pom.xml
@@ -83,7 +83,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
-		        <version>3.0.0</version>
+		        <version>3.1.0</version>
                 <configuration>
                     <failsOnError>true</failsOnError>
                     <configLocation>../checkstyle.xml</configLocation>