Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update last_code_generated in smart_dataframe's __init__.py #1484

Conversation

bence-kecskes
Copy link
Contributor

@bence-kecskes bence-kecskes commented Dec 18, 2024

In SmartDataframe class the last_code_generated property returned _agent.last_code_executed instead of _agent.last_code_generated. In SmartDatalake it is implemented properly.


Important

Fix last_code_generated in SmartDataframe to return _agent.last_code_generated.

  • Behavior:
    • Fix last_code_generated property in SmartDataframe to return _agent.last_code_generated instead of _agent.last_code_executed.

This description was created by Ellipsis for 741a9f9. It will automatically update as commits are pushed.

In SmartDataframe class the last_code_generated property returned _agent.last_code_executed instead of _agent.last_code_generated. In SmartDatalake it is implemented properly.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 18, 2024
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 741a9f9 in 11 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pandasai/smart_dataframe/__init__.py:173
  • Draft comment:
    The change correctly updates the property to return _agent.last_code_generated instead of _agent.last_code_executed, aligning with the intended functionality.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the PR correctly updates the property to return the intended attribute, aligning with the description provided.

Workflow ID: wflow_fQ7TEP2P73LQ2TY1


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@gventuri
Copy link
Collaborator

@bence-kecskes thanks a lot, merging it right away!

@gventuri gventuri merged commit 34535a2 into Sinaptik-AI:main Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants