Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multi-round conversion with Bedrock Claude #1111

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Conversation

goriri
Copy link
Contributor

@goriri goriri commented Apr 15, 2024

@gventuri
Copy link
Collaborator

@goriri can you provide slightly more context about this fix? I don't understand exactly why we are overriding the previous message in the conversation. Does bedrock raise an error if there are 2 user messages in a row?

@gventuri
Copy link
Collaborator

@goriri let me know, so we can merge :)

@goriri
Copy link
Contributor Author

goriri commented Apr 19, 2024

@gventuri
yes. it will complain when two user messages in a row (requiring alternating user/assistant messages). in a single message, the content can contain multiple text sections.

@gventuri
Copy link
Collaborator

Thanks a lot for letting me know, merging! @goriri

@gventuri gventuri merged commit 72891ea into Sinaptik-AI:main Apr 19, 2024
2 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants