Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env var support for ssl mode #1

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Conversation

benwalk
Copy link

@benwalk benwalk commented Jul 9, 2020

Description

SSL mode for the database connection string was not configurable. This change allows configuration of this via env var DB_SSL_MODE.

Motivation and Context

Enabling encrypted connections to backend databases should be allowed.

This issue is filed upstream at cloudfoundry#4434.

How Has This Been Tested?

The existing tests validate TLS connection strings work.

The value of the supplied mode is already validated here.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Docs update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have followed the guidelines in CONTRIBUTING.md, including the required formatting of the commit message

@benwalk benwalk merged commit 6376ab6 into master Jul 9, 2020
@benwalk benwalk deleted the INFRA-601/ssl-config-env branch July 27, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant