This repository has been archived by the owner on Nov 17, 2018. It is now read-only.
fix windows aws ssl cert verification #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sensu ruby install on Windows doesn't include the proper certs (or if it does they're not loaded properly) to connect to AWS. `@sns.publish` generates an error like: ``` C:/opt/sensu/embedded/lib/ruby/2.0.0/net/http.rb:921:in `connect': SSL_connect returned=1 errno=0 state=error: certificate verify failed (Seahorse::Client::NetworkingError) ``` Using the cert bundle included with the aws-sdk-core gem should work around this. Sourced from amazon-archives/aws-sdk-core-ruby#166 (comment)
|
@tomwans what about merging this stuff? |
|
Is this still an issue? I don't have any access to any Windows boxes to run this test to verify. That said, I'm wary of merging any Windows features into our codebase. Since we don't run any Windows hosts at Simple, we don't really have any way to support this code. If you're running on Windows hosts, I think your best bet would be to fork this repo and add Windows support there. I'd like to add that I spoke with my team and we clarified our expectations for this repository in 1190312. TL;DR, we're happy to accept patches for valid bugs, but we're likely not going to consider PRs that add new features (such as Windows support). That said, I'm going to close this out. |
autarchprinceps
pushed a commit
to autarchprinceps/sensu-transport-snssqs
that referenced
this pull request
Jan 23, 2018
Fix contributed via SimpleFinance#7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sensu ruby install on Windows doesn't include the proper certs (or
if it does they're not loaded properly) to connect to AWS.
@sns.publishgenerates an error like:Using the cert bundle included with the aws-sdk-core gem should work
around this.
Sourced from amazon-archives/aws-sdk-core-ruby#166 (comment)