Refactor model loading #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这笔 pr 与 #11 似乎有部分重复了，我们一笔一笔合吧 |
Signed-off-by: ZhuohaoHe <[email protected]>
Signed-off-by: ZhuohaoHe <[email protected]>
|
根据 #11 的review重新更改了这笔，已通过build部分的CI |
MRNIU
reviewed
Aug 26, 2024
src/include/config.h
Outdated
src/include/material.hpp
Outdated
| @@ -0,0 +1,39 @@ | |||
| #pragma once | |||
ZzzhHe
force-pushed
the
refactor-model-loading
branch
from
7e943f9 to
787740c
Compare
Signed-off-by: ZhuohaoHe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
tinyobjloaderwith theassimpto support a wide range of model format in the future. ( currently the project still focus on loading the.objfile.)Test Platform
macOS 14.5
Linux (Ubuntu 20.04)
TODO:
simple_rendererclass to split it into several smaller, more focused classes.