Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

similar_type implementation #118

Merged
merged 6 commits into from
Jun 1, 2016
Merged

similar_type implementation #118

merged 6 commits into from
Jun 1, 2016

Commits on May 28, 2016

  1. Remove obsolete versions of map()

    It's now no longer necessary to have the versions taking a Type{T}
    parameter, since the unary version of map now correctly inferrs the
    output FSA type.  (And the comment here was wrong.)
    c42f committed May 28, 2016
    Configuration menu
    Copy the full SHA
    2d3d351 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2016

  1. similar -> similar_type

    * Rename similar to similar_type since it produces slightly different
      output.
    * Implement default similar_type which returns the type unchanged if it
      exactly matches, and falls back to Vec/Mat otherwise
    * Implement similar_type for Vec,Point,Mat and tests as necessary.
    c42f committed May 29, 2016
    Configuration menu
    Copy the full SHA
    853782c View commit details
    Browse the repository at this point in the history

Commits on May 31, 2016

  1. Some tests for FSA not parameterized by size and eltype

    Chris Foster committed May 31, 2016
    Configuration menu
    Copy the full SHA
    0d977cb View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2016

  1. Documentation for FSA types and the similar_type function

    * Document FSA abstract types which are actually in use (no docs for
      Mutable FSAs yet, since I'm not sure anybody is using them)
    * Document concrete FSA types provided by the package
    * Document the requirement to overload `similar_type` in certian cases.
    Chris Foster committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    7cc58f4 View commit details
    Browse the repository at this point in the history
  2. Cleanup similar_type a little

    * Avoid some duplication in similar_type definitions
    * Move `@pure` somewhere more sensible
    * Remove similar_type convenience function for simplicity
    c42f authored and Chris Foster committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    39a9595 View commit details
    Browse the repository at this point in the history
  3. Crazy type introspection for default similar_type

    Make similar_type() work by default in nearly all circumstances, by
    introspecting the type tree using fsa_abstract(), supertype() and a
    bunch of other ugly stuff involving `TypeVar`s.  Ugh... just ugh, but I
    hope it'll make it easier for users.
    
    * Remove the specialized similar_type() implementations for concrete
      types as they're no longer needed
    * Fix up README to reflect the new implementation
    * Add some extra tests
    Chris Foster committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    34bc334 View commit details
    Browse the repository at this point in the history