Repository navigation
Fix Random.NextSingle being able to return 1.0 - #666
Merged
Merged
Conversation
This was referenced Oct 12, 2026
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The
Random.NextSinglepolyfill (below net6) was(float) target.NextDouble(). Adoublejust below 1.0 rounds up to exactly1.0fwhen cast, which is outside the documented[0, 1)range. It is rare but real:new Random(0)returns1.0fon call 5,800,140 on net48.Fix
Sample again while the cast result is not below
1f. This is what the BCL does for its seeded implementation.Test
RandomNextSingle_NeverReturnsOnetakes 5,900,000 values fromnew Random(0)and asserts the maximum is below1.0fand the minimum is not below0.0f. It failed on net48 before the fix (maximum was1), and passes on net462 and net48 (polyfill) and net10.0 (BCL).