Repository navigation
Do not polyfill File.OpenNullHandle on net11 - #650
Merged
Merged
Conversation
SimonCropp
force-pushed
the
fix/opennullhandle-net11
branch
from
October 11, 2026 22:18
3c2c67d to
0093388
Compare
This was referenced Oct 12, 2026
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
File.OpenNullHandlewas guarded by#if !NET12_0_OR_GREATER, but the method ships in net11 (present in theMicrosoft.NETCore.App.Ref11.0.0-rc.1 pack pinned byglobal.json, absent from 10.0.12). On net11 the polyfill was dead code and counted as a polyfilled API.Consume.cshid this by only calling it under#if !NET11_0_OR_GREATER.Fix
#if !NET11_0_OR_GREATER(the block also holdsHardLinkHelper/NullDeviceHelper, which are only needed below net11).Consume.csnow callsFile.OpenNullHandle()on every TFM.Coverage
FilePolyfillTests.OpenNullHandle_NotPolyfilledWhereBclHasItasserts via reflection thatPolyfills.Polyfilldoes not declareOpenNullHandlewhenSystem.IO.Filedoes. Fails on net11.0 before the fix; passes on net48, net10.0 and net11.0 after.OpenNullHandletest exercises the polyfill below net11 and the BCL on net11.Split files and API counts regenerated (net11.0: 58 -> 57;
src/Split/net11.0/FilePolyfill.csis now empty and removed).