Repository navigation
Fix TextReader.ReadAsync(Memory<char>) dropping data for non array-backed memory - #644
Merged
Merged
Conversation
This was referenced Oct 12, 2026
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
TextReader.ReadAsync(Memory<char>, CancellationToken)fell back tobuffer.ToArray()when the memory was not array-backed (MemoryMarshal.TryGetArrayreturns false, e.g. a customMemoryManager<char>or native memory). The read went into that temporary copy and was never copied back, so the caller's buffer stayed untouched while the returned count said chars had been read.Fix
Same approach as the BCL: rent an array from
ArrayPool<char>.Shared, read into it, copy the chars read into the destination memory, and return the array. The array is only returned to the pool once the underlying read has completed, since a cancellation viaWaitAsynccan leave the read in flight. The array-backed path is unchanged.Test
TextReader_ReadAsync_Memory_NotArrayBackedreads into a slice of aMemoryManager<char>that does not overrideTryGetArrayand checks the destination contents. Fails on net48 before the fix; passes on net48 and on net10.0 (BCL).