Repository navigation
Make ReadOnlySpan<char>.StartsWith/EndsWith(string) ordinal - #637
Merged
Merged
Conversation
SimonCropp
force-pushed
the
fix/span-startswith-endswith-ordinal
branch
from
October 12, 2026 02:04
ef8530c to
890bdc2
Compare
This was referenced Oct 12, 2026
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Below netcoreapp3.0 the polyfills were declared as
so
span.EndsWith("c")did a current-culture comparison. On newer frameworks the same call binds toMemoryExtensions.EndsWith<T>(ReadOnlySpan<T>, ReadOnlySpan<T>), which is ordinal. For example"abc".AsSpan().EndsWith("c")returnedtrueon net48 andfalseon net10.0 (the soft hyphen is ignored by culture-sensitive comparison).Fix
Each method is split into two overloads: one without a comparison that does the ordinal sequence comparison, and one with a required
StringComparison. The API count goes up by two as a result.Test
ReadOnlySpan_StartsWith_String_IsOrdinalandReadOnlySpan_EndsWith_String_IsOrdinalinPolyfillTests_Memory.cscheck that the no-comparison call does not ignore a soft hyphen, that the explicitInvariantCulturecall does, and that an exact ordinal match still succeeds. Both failed on net48 before the fix and pass on net48 (polyfill) and net10.0 (BCL) after it.