Repository navigation
Fix Enumerable.Sequence for NaN arguments and a zero step - #633
Merged
Merged
Conversation
This was referenced Oct 12, 2026
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The
Enumerable.Sequencepolyfill (net7 to net9) diverged from the net10 BCL:NaNstart,endInclusiveorstepwas not rejected. Every comparison withNaNis false, so the result was an endless sequence. The BCL throwsArgumentOutOfRangeExceptionat the call, naming the offending parameter.stepwas treated as a negative step, soSequence(1, 5, 0)threw forendInclusiveandSequence(5, 1, 0)returned[5]. The BCL throwsArgumentOutOfRangeExceptionforstepunlessstart == endInclusive, in which case it yields the single value.paramName("endInclusive < start"). The BCL usesendInclusive.Fix
Mirror the BCL: reject
NaNup front, branch onstep > 0/step < 0, and handlestep == 0(including-0.0) separately. Exceptions now carry the sameParamNameas the BCL.Test
New
Sequence_*tests for aNaNstart, end and step, a zero and negative-zero step, a zero step withstart == endInclusive, and theParamNameof the existing range checks. None of them enumerate, since the checks are not deferred. Five of the six failed on net8.0 before the fix. They pass on net8.0 and net9.0 (polyfill) and net10.0 (BCL). The expected behaviour was confirmed against net10 first. The net7.0 runtime is not installed on this machine, so net7.0 was compiled but not run.