Repository navigation
Match BCL parameter types for TimeSpan.FromDays/FromHours/FromMinutes - #632
Merged
Merged
Conversation
This was referenced Oct 12, 2026
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The multi-argument
TimeSpanfactory polyfills declared every parameter asint:FromDays(int, int, int, int, int, int)FromHours(int, int, int, int, int)FromMinutes(int, int, int, int)The BCL (net9 reference assemblies) declares:
FromDays(int, int, long, long, long, long)FromHours(int, long, long, long, long)FromMinutes(long, long, long, long)So code passing
longarguments compiled on net9+ but failed with CS1503 on every TFM that uses the polyfill, and values outside the Int32 range could not be expressed.Fix
Parameter types (and the
//Link:overload anchors) now match the BCL. The implementation already accumulated indecimal, so no other change was needed.Coverage
FromDays_LongComponents,FromHours_LongComponents,FromMinutes_LongComponentstests passlongarguments, including values larger thanint.MaxValue(run on net48, net8.0 and net10.0).Consume.cscalls the three overloads withlongarguments.api_list.include.mdregenerated.