Repository navigation
Do not capture the SynchronizationContext in ConfigureAwait(ConfigureAwaitOptions) - #630
Merged
Merged
Conversation
This was referenced Oct 12, 2026
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The
Task.ConfigureAwait(ConfigureAwaitOptions)polyfill (and theTask<TResult>overload) implementedForceYieldingandSuppressThrowingwith local async wrappers:Both wrappers await without
ConfigureAwait(false), so they capture the currentSynchronizationContexteven when the caller did not passContinueOnCapturedContext.await task.ConfigureAwait(ConfigureAwaitOptions.ForceYielding)therefore deadlocks when the context thread is blocked, where the BCL completes.SuppressThrowingalso paid for a throw and catch on every faulted or canceled task.Fix
ForceYielding:Task.Run(() => task), which always queues to the thread pool and unwraps to the original outcome.SuppressThrowing: aContinueWithonTaskScheduler.DefaultwithExecuteSynchronouslythat readsException(marking it observed) and completes successfully. No exception is thrown.ContinueOnCapturedContextis still honoured by the finalConfigureAwait(bool)on the resulting task.Test
Added to
PolyfillTests_Task_ConfigureAwait.cs:ForceYielding(both overloads) andSuppressThrowingawaited on a thread whoseSynchronizationContext.Postnever runs must complete within a timeout. These three timed out on net48 before the fix. Also added coverage forSuppressThrowingon a pending task andForceYieldingpropagating a fault.