Skip to content
/ jest Public
forked from jestjs/jest
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs instanceof array e2e test and fix #155

Closed

Conversation

chekkan
Copy link

@chekkan chekkan commented Feb 12, 2019

Summary

This is to contribute to the pull request jestjs#5995.

Added e2e test for Array instanceof error. I was able to reproduce this error locally with jest version 24.1.0 and "testEnvironment": "node" as reported in the original issue jestjs#2549. And verified this change against it and saw it working.

I couldn't reproduce this issue in "testEnvironment": "jsdom". And I couldn't fail the e2e tests against node version 6, 8, and 10 as well.

Test plan

Node version 6

node --version
v6.14.3
➜ pwd
/Users/chekkan/dev/facebook/jest/e2e/instanceof
➜ node ../../packages/jest-cli/bin/jest.js
 PASS  __tests__/test.js
  ✓ fs Error (5ms)
  ✓ http error (96ms)
  ✓ querystring parse array (1ms)

Test Suites: 1 passed, 1 total
Tests:       3 passed, 3 total
Snapshots:   0 total
Time:        1.051s
Ran all test suites.

Node version 8

➜ node --version
v8.11.1
➜ pwd
/Users/chekkan/dev/facebook/jest/e2e/instanceof
➜ node ../../packages/jest-cli/bin/jest.js
 PASS  __tests__/test.js
  ✓ fs Error (4ms)
  ✓ http error (14ms)
  ✓ querystring parse array (3ms)

Test Suites: 1 passed, 1 total
Tests:       3 passed, 3 total
Snapshots:   0 total
Time:        0.798s
Ran all test suites.

Node version 10

➜ node --version
v8.11.1
➜ pwd
/Users/chekkan/dev/facebook/jest/e2e/instanceof
➜ node ../../packages/jest-cli/bin/jest.js
 PASS  __tests__/test.js
  ✓ fs Error (4ms)
  ✓ http error (13ms)
  ✓ querystring parse array (1ms)

Test Suites: 1 passed, 1 total
Tests:       3 passed, 3 total
Snapshots:   0 total
Time:        0.763s
Ran all test suites.

@chekkan chekkan closed this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant