nodejs instanceof array e2e test and fix #155
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is to contribute to the pull request jestjs#5995.
Added e2e test for
Array
instanceof
error. I was able to reproduce this error locally with jest version24.1.0
and"testEnvironment": "node"
as reported in the original issue jestjs#2549. And verified this change against it and saw it working.I couldn't reproduce this issue in
"testEnvironment": "jsdom"
. And I couldn't fail the e2e tests against node version 6, 8, and 10 as well.Test plan
Node version 6
Node version 8
Node version 10