Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 -> v4 #335

Merged
merged 3 commits into from
Feb 7, 2025
Merged

v3 -> v4 #335

merged 3 commits into from
Feb 7, 2025

Conversation

mrp089
Copy link
Member

@mrp089 mrp089 commented Feb 6, 2025

Current situation

Current pipeline fails because v3 is outdated

Release Notes

v3 -> v4

Testing

Let's see if this pipeline runs

Code of Conduct & Contributing Guidelines

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.54%. Comparing base (1a27c43) to head (f0f28a0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   65.65%   64.54%   -1.12%     
==========================================
  Files         114      147      +33     
  Lines       29416    30376     +960     
  Branches        0     4774    +4774     
==========================================
+ Hits        19312    19605     +293     
- Misses      10104    10638     +534     
- Partials        0      133     +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrp089
Copy link
Member Author

mrp089 commented Feb 7, 2025

Successfully updated everything to actions/upload-artifact@v4. Turns out we were uploading code coverage twice, on ubuntu20 and ubuntu22, which v3 was fine with but v4 didn't allow. Now only checking and uploading coverage on ubuntu22. Should fix #325 and #331.

@mrp089 mrp089 requested a review from dcodoni February 7, 2025 01:31
Copy link
Contributor

@dcodoni dcodoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrp089, it looks great!

@dcodoni dcodoni merged commit d272890 into SimVascular:main Feb 7, 2025
5 checks passed
@mrp089 mrp089 deleted the update_checkout branch February 7, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants