Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EF Template Compatibility #403

Merged
merged 17 commits into from
Dec 5, 2024
Merged

EF Template Compatibility #403

merged 17 commits into from
Dec 5, 2024

Conversation

wersal454
Copy link

What type of PR is this?

  1. Bug
  2. Change
  3. Enhancement
  4. Miscellaneous

What have you changed and why?

Information:

ported and adapted templates from community official-antistasi-community#3441
also port of official-antistasi-community#3442

Please specify which Issue this PR Resolves (If Applicable).

"This PR closes #XXXX!"

Please verify the following.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:

Notes:

@wersal454 wersal454 marked this pull request as draft November 30, 2024 23:50
@SilenceIsFatto SilenceIsFatto changed the title Ef compatibility EF Template Compatibility Nov 30, 2024
@wersal454
part 2
e17c785 
next stop, weapons and gear
@wersal454
part 3
7e392b1 
next stop, logistics
@wersal454
Copy link
Author

Also, don't forget about doing "prices" in Vehicle_Attributes

@wersal454
part 4
658487d 
finished

Next stop, QRFNaval?
@wersal454 wersal454 marked this pull request as ready for review December 3, 2024 22:11
@wersal454
Copy link
Author

Untested

Need to launch every template to check if there are any errors
Also need to check cargo config for the new turret

@wersal454
part 4.1
d585166 
Oups, almost forgot
@SilenceIsFatto SilenceIsFatto added this to the v11.4.0 milestone Dec 4, 2024
@SilenceIsFatto SilenceIsFatto added the faction/template A new faction or template label Dec 4, 2024
SilenceIsFatto
SilenceIsFatto requested changes Dec 4, 2024
View reviewed changes
SilenceIsFatto
SilenceIsFatto requested changes Dec 4, 2024
View reviewed changes
Copy link
Owner

@SilenceIsFatto SilenceIsFatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check the Vanilla_AI_XYZ templates as quite a few are missing the private _hasEF = "ef" in A3A_enabledDLC; declaration

wersal454 and others added 7 commits December 4, 2024 20:40
SilenceIsFatto
SilenceIsFatto requested changes Dec 5, 2024
View reviewed changes
Copy link
Owner

@SilenceIsFatto SilenceIsFatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3 Vanilla_AI_NATO_Side templates are missing the _gunBoat variable used in DLC_content includes, should double check for any other variables missed

SilenceIsFatto
SilenceIsFatto approved these changes Dec 5, 2024
View reviewed changes
Copy link
Owner

@SilenceIsFatto SilenceIsFatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@AUC-bot AUC-bot merged commit 3eefd01 into SilenceIsFatto:unstable Dec 5, 2024
@SilenceIsFatto SilenceIsFatto mentioned this pull request Dec 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilenceIsFatto SilenceIsFatto SilenceIsFatto approved these changes

Assignees
No one assigned
Labels
faction/template A new faction or template ready-for-merge
Projects
None yet
Milestone
v11.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wersal454 @SilenceIsFatto @AUC-bot