refactor(backend): Simplify CredentialsField usage + use ProviderName globally
#8725
+223
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `credentials` inputs - Add `credentials_provider` and `credentials_types` to field schema from `CredentialsMetaInput` instead of `CredentialsField` - Remove `provider` and `supported_credential_types` params from `CredentialsField` and all its usages - Add `credentials` schema validation logic to `CredentialsMetaInput`, which is called from `BlockSchema.__pydantic_init_subclass__`
- Add missing providers to `ProviderName`
- Replace string literals for provider names with `ProviderName.{PROVIDER}` on blocks and in `CredentialsMetaInput`, `BlockWebhookConfig`, `*OAuthHandler`
- docs: Update instructions for blocks with authentication
Pwuts
requested review from
Bentlybro and
majdyz
and removed request for
a team
github-actions
bot
added
documentation
…k' into reinier/make-providername-enum
14 tasks
|
Haven't reviewed or tested yet - but is this going to be a breaking change for ppls existing blocks at all? |
Nope, this is purely a refactor for DX purposes. Serialization and validation of existing objects shouldn't be affected. |
Pwuts
force-pushed
the
reinier/open-1961-implement-github-on-pull-request-block
branch
from
c415bd0
to
397ae0b
Compare
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProviderNamefills that gap.credentialsinput currently requires defining the provider and credential type(s) both onCredentialsMetaInputandCredentialsField. For better DX, this redundancy should be removed, but without compromising schema generation and data validation.Changes 🏗️
credentialsinputsProviderNameenum globally