Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validate_json scheme path #3631

Conversation

k-boikov
Copy link
Contributor

@k-boikov k-boikov commented May 1, 2023

Background

validate_json is throwing error when used from tests
image

Changes

Set scheme patch to be relative to the .py file

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented May 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) May 1, 2023 6:01pm

@github-actions github-actions bot added the size/s label May 1, 2023
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a5f8563) 60.28% compared to head (842d1dd) 60.28%.

❗ Current head 842d1dd differs from pull request most recent head b4cc46b. Consider uploading reports for the commit b4cc46b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3631   +/-   ##
=======================================
  Coverage   60.28%   60.28%           
=======================================
  Files          69       69           
  Lines        3150     3150           
  Branches      525      526    +1     
=======================================
  Hits         1899     1899           
  Misses       1118     1118           
  Partials      133      133           
Impacted Files Coverage Δ
autogpt/json_utils/utilities.py 68.57% <100.00%> (+1.90%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@k-boikov k-boikov force-pushed the improvement/fix-validate-json-for-tests branch from e66a268 to f0d4d52 Compare May 1, 2023 15:46
@k-boikov k-boikov force-pushed the improvement/fix-validate-json-for-tests branch from f0d4d52 to 1a6edff Compare May 1, 2023 15:47
@k-boikov k-boikov marked this pull request as ready for review May 1, 2023 15:51
@k-boikov k-boikov added bug Something isn't working invalid_json Groups issues and PRs related to invalid json error or similar labels May 1, 2023
Co-authored-by: Reinier van der Leer <[email protected]>
@k-boikov k-boikov mentioned this pull request May 1, 2023
5 tasks
@Pwuts Pwuts self-assigned this May 1, 2023
@Pwuts Pwuts changed the title Fix validate_json scheme path Fix validate_json scheme path May 1, 2023
@Pwuts Pwuts merged commit 0ef6f06 into Significant-Gravitas:master May 1, 2023
@k-boikov k-boikov deleted the improvement/fix-validate-json-for-tests branch May 1, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid_json Groups issues and PRs related to invalid json error or similar size/s
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants