Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/test summarization against memory challenge #3567

Merged
merged 23 commits into from
Apr 30, 2023
Merged

Feature/test summarization against memory challenge #3567

merged 23 commits into from
Apr 30, 2023

Conversation

waynehamadi
Copy link
Contributor

@waynehamadi waynehamadi commented Apr 30, 2023 •
edited
Loading

Background

In progress

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented Apr 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Apr 30, 2023 8:43am

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/test-summarization-againt-memory-challenge branch from 1305168 to 76edfbe Compare April 30, 2023 06:57
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/test-summarization-againt-memory-challenge branch from 76edfbe to 5e8e004 Compare April 30, 2023 07:05
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi changed the base branch from master to summary_memory April 30, 2023 07:09
@waynehamadi waynehamadi changed the base branch from summary_memory to preserve-permanent-memory-implementation April 30, 2023 07:09
@waynehamadi waynehamadi changed the base branch from preserve-permanent-memory-implementation to summary_memory April 30, 2023 07:10
@waynehamadi waynehamadi changed the base branch from summary_memory to master April 30, 2023 07:11
@waynehamadi waynehamadi force-pushed the feature/test-summarization-againt-memory-challenge branch from 5e8e004 to 43504a2 Compare April 30, 2023 07:20
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/test-summarization-againt-memory-challenge branch from 43504a2 to 8b0c6a3 Compare April 30, 2023 07:29
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/test-summarization-againt-memory-challenge branch from 8b0c6a3 to e2eba59 Compare April 30, 2023 07:30
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/test-summarization-againt-memory-challenge branch from e2eba59 to 0374c68 Compare April 30, 2023 07:35
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/test-summarization-againt-memory-challenge branch from 0374c68 to 8a4f451 Compare April 30, 2023 07:46
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/test-summarization-againt-memory-challenge branch from 8a4f451 to 914075d Compare April 30, 2023 08:00
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

1 similar comment
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@codecov
Copy link

codecov bot commented Apr 30, 2023 •
edited
Loading

Codecov Report

Patch coverage: 90.24% and project coverage change: +0.48 🎉

Comparison is base (064ac5c) 59.14% compared to head (6720471) 59.62%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3567      +/-   ##
==========================================
+ Coverage   59.14%   59.62%   +0.48%     
==========================================
  Files          68       69       +1     
  Lines        3062     3091      +29     
  Branches      502      509       +7     
==========================================
+ Hits         1811     1843      +32     
+ Misses       1120     1118       -2     
+ Partials      131      130       -1
Impacted Files Coverage Δ
autogpt/memory_management/summary_memory.py 87.50% <87.50%> (ø)
autogpt/agent/agent.py 45.11% <100.00%> (+0.83%) ⬆️
autogpt/llm/chat.py 73.49% <100.00%> (+7.58%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynehamadi waynehamadi force-pushed the feature/test-summarization-againt-memory-challenge branch from 21c34f7 to 22d194e Compare April 30, 2023 08:16
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/test-summarization-againt-memory-challenge branch from 22d194e to 74f0201 Compare April 30, 2023 08:25
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 30, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

Torantulino and others added 21 commits April 30, 2023 01:34
@Torantulino @waynehamadi
Add running summary memory functions.
9923d82
@Torantulino @waynehamadi
Remove test prints
22699d3
@Torantulino @waynehamadi
Add complete typing and docstrings
040383a
@Torantulino @waynehamadi
Black formatting
9e0ac77
@Torantulino @waynehamadi
Run isort.
d71aecb
@Torantulino @waynehamadi
Integrate summary memory with autogpt system
fa308da
@Torantulino @waynehamadi
Run black formatter
3ea60e0
@Torantulino @waynehamadi
Remove global pre_index from summary_memory.
2356aa8
@Torantulino @waynehamadi
Replace "assistant" role with "you" when sumbitting to memory agent.
244eedc
@Torantulino @waynehamadi
Provide default new_events value when empty.
bf5a285
@Torantulino @waynehamadi
Fix. Update last_memory_index
2c4fe53
@Torantulino @waynehamadi
Adds check for empty full_message_history
58aa056
@Torantulino @waynehamadi
removes current memory global
d18949e
@Torantulino @waynehamadi
Update autogpt/memory_management/summary_memory.py
a1001ea
@Torantulino @waynehamadi
Update autogpt/memory_management/summary_memory.py
96f7900
@Torantulino @waynehamadi
Change "system" role to "Your Computer".
657f093
@Torantulino @waynehamadi
Remove thoughts from memory summarisation.
09e5c9e
@Torantulino @waynehamadi
fix broken partial commit.
a00e30c
@Torantulino @waynehamadi
Tweak memory summarisation prompt
8fa40ca
@Torantulino @waynehamadi
Run Black and Isort
df18d15
@waynehamadi
solve conflicts
31052d8
@waynehamadi waynehamadi force-pushed the feature/test-summarization-againt-memory-challenge branch from 076e561 to f002e26 Compare April 30, 2023 08:37
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/test-summarization-againt-memory-challenge branch from f002e26 to adc5666 Compare April 30, 2023 08:43
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@richbeales richbeales merged commit dd96d98 into Significant-Gravitas:master Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richbeales richbeales richbeales approved these changes

Assignees
No one assigned
Labels
size/xl
Projects
AutoGPT development kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waynehamadi @richbeales @Torantulino