Skip to content

Feature/challenge memory challenge B #3550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2023
Merged

Feature/challenge memory challenge B #3550

merged 1 commit into from
Apr 30, 2023

Conversation

waynehamadi
Copy link
Contributor

Background

Master only beats memory challenge B level 1. It fails at level 2.
By adding this challenge we can test the new summary implementation of Toran

Changes

  • Put one task id per file
  • put noise in the file to quickly consume all the context window.

Expected result: auto-gpt should remember all the ids.

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented Apr 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Apr 30, 2023 0:36am

@waynehamadi waynehamadi changed the title Feature/challenge memory management b Feature/challenge memory challenge B Apr 29, 2023
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/challenge-memory-management-b branch from 9f2df31 to 58500b4 Compare April 29, 2023 22:13
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/challenge-memory-management-b branch from 58500b4 to ec2d085 Compare April 29, 2023 22:25
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/challenge-memory-management-b branch from ec2d085 to 54d8161 Compare April 29, 2023 22:27
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/challenge-memory-management-b branch from 54d8161 to f94fce5 Compare April 29, 2023 22:31
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/challenge-memory-management-b branch from f94fce5 to 43d103f Compare April 29, 2023 22:34
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/challenge-memory-management-b branch from 43d103f to 6eaebc1 Compare April 29, 2023 22:38
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/challenge-memory-management-b branch from 6eaebc1 to e528828 Compare April 29, 2023 22:51
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/challenge-memory-management-b branch from e528828 to 67fa51e Compare April 29, 2023 23:01
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/challenge-memory-management-b branch from 67fa51e to 98dcb23 Compare April 29, 2023 23:12
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/challenge-memory-management-b branch from 98dcb23 to a6aae17 Compare April 29, 2023 23:19
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/challenge-memory-management-b branch from a6aae17 to 43302ed Compare April 29, 2023 23:22
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@codecov
Copy link

codecov bot commented Apr 29, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (cdd91f7) 58.26% compared to head (8bbb2c8) 58.26%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3550   +/-   ##
=======================================
  Coverage   58.26%   58.26%           
=======================================
  Files          68       68           
  Lines        3079     3079           
  Branches      516      516           
=======================================
  Hits         1794     1794           
  Misses       1148     1148           
  Partials      137      137

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynehamadi
Copy link
Contributor Author

code coverage is the same but these challenges give us prompt coverage

@waynehamadi waynehamadi force-pushed the feature/challenge-memory-management-b branch from 43302ed to c0b9f3a Compare April 30, 2023 00:30
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/challenge-memory-management-b branch from c0b9f3a to eff7a16 Compare April 30, 2023 00:32
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

p-i-
p-i- previously approved these changes Apr 30, 2023
View reviewed changes
@waynehamadi
memory challenge B
8bbb2c8 
Signed-off-by: Merwane Hamadi <[email protected]>
@waynehamadi waynehamadi force-pushed the feature/challenge-memory-management-b branch from eff7a16 to 8bbb2c8 Compare April 30, 2023 00:36
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@p-i- p-i- merged commit 6997bb0 into Significant-Gravitas:master Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torantulino Torantulino Torantulino approved these changes

@p-i- p-i- p-i- left review comments

Assignees
No one assigned
Labels
size/xl
Projects
AutoGPT development kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waynehamadi @p-i- @Torantulino