Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test_chat to use pytest instead of unittest #3484

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

rihp
Copy link
Contributor

@rihp rihp commented Apr 28, 2023

Background

we are deprecating unittest in favor of pytest

related to

Changes

only to the test_chat file

Documentation

not necessary

Test Plan

running pytest

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Apr 28, 2023 6:15pm

@rihp rihp marked this pull request as ready for review April 28, 2023 18:05
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c1f1da2) 56.46% compared to head (e021f69) 56.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3484   +/-   ##
=======================================
  Coverage   56.46%   56.46%           
=======================================
  Files          65       65           
  Lines        3018     3018           
  Branches      507      507           
=======================================
  Hits         1704     1704           
  Misses       1175     1175           
  Partials      139      139           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@collijk collijk merged commit ee4043a into Significant-Gravitas:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants