Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orjson on macOS #3457

Closed
wants to merge 1 commit into from
Closed

Fix orjson on macOS #3457

wants to merge 1 commit into from

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Apr 28, 2023

Background

Changes

  • Specify orjson version >= 3.8.11

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Apr 28, 2023 9:15am

@Pwuts Pwuts added bug Something isn't working platform dependent When something works but not on all platforms labels Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1772a01) 54.86% compared to head (bb55ff1) 54.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3457   +/-   ##
=======================================
  Coverage   54.86%   54.86%           
=======================================
  Files          65       65           
  Lines        3020     3020           
  Branches      508      508           
=======================================
  Hits         1657     1657           
  Misses       1227     1227           
  Partials      136      136           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pwuts Pwuts self-assigned this Apr 28, 2023
@zyt600
Copy link
Contributor

zyt600 commented Apr 28, 2023

Hi, I am the poster of the issue, seems like we should write "orjson==3.8.10" instead of "orjson>=3.8.11" because the issue will appear when we use orjson with version 3.8.11 and the issue disappears when we use orjson==3.8.10.

@Pwuts Pwuts closed this Apr 28, 2023
@kskk02
Copy link

kskk02 commented Apr 29, 2023

Is this fix on the stable branch ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform dependent When something works but not on all platforms size/s
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

build error with M1 mac
3 participants