Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set vcr_config scope to "session" #3361

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

Androbin
Copy link
Contributor

Background

ScopeMismatch: You tried to access the function scoped fixture vcr_config with a module scoped request object, involved factories:
../../../.local/lib/python3.10/site-packages/pytest_vcr.py:42:  def _vcr_marker(request)
../../../.local/lib/python3.10/site-packages/pytest_vcr.py:82:  def vcr_cassette(request, vcr, vcr_cassette_name)
../../../.local/lib/python3.10/site-packages/pytest_vcr.py:65:  def vcr(request, vcr_config, vcr_cassette_dir)
tests/integration/conftest.py:6:  def vcr_config()

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 1:47am

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (02f546d) 51.22% compared to head (3411b7d) 51.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3361   +/-   ##
=======================================
  Coverage   51.22%   51.22%           
=======================================
  Files          65       65           
  Lines        2975     2975           
  Branches      502      502           
=======================================
  Hits         1524     1524           
  Misses       1331     1331           
  Partials      120      120           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pwuts Pwuts added the testing label Apr 27, 2023
@vercel vercel bot temporarily deployed to Preview April 27, 2023 01:47 Inactive
@BillSchumacher BillSchumacher merged commit 76bd192 into Significant-Gravitas:master Apr 27, 2023
@Androbin Androbin deleted the patch-5 branch April 27, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants