Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up image generation tests #3338

Merged

Conversation

collijk
Copy link
Contributor

@collijk collijk commented Apr 26, 2023

Background

Working from @merwanehamadi 's changes to make these tests work correctly and remove some code duplication.

Changes

  • Parameterize image size so all models are tested over several sizes.
  • Extract a function to generate an image with a provider and validate the image size.
  • Remove the request args from the funcs as they are not used and a holdover from a closed PR.
  • Mark the SD WebUI as xfail because they fail for me.

Documentation

N/A

Test Plan

All testing here.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Apr 26, 2023 6:10pm

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -7.47 ⚠️

Comparison is base (109fa04) 51.03% compared to head (bc87b3c) 43.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3338      +/-   ##
==========================================
- Coverage   51.03%   43.57%   -7.47%     
==========================================
  Files          65       65              
  Lines        2935     2935              
  Branches      492      492              
==========================================
- Hits         1498     1279     -219     
- Misses       1316     1582     +266     
+ Partials      121       74      -47     

see 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@collijk collijk merged commit 83f1146 into Significant-Gravitas:master Apr 26, 2023
@collijk collijk deleted the bugfix/clean-up-image-gen-tests branch April 26, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants