Add makedirs to file operations #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdkiller
previously approved these changes
Apr 26, 2023
ntindle
requested changes
Apr 26, 2023
1 task
|
Added tests |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3289 +/- ##
==========================================
+ Coverage 51.37% 51.42% +0.04%
==========================================
Files 65 65
Lines 3013 3016 +3
Branches 508 507 -1
==========================================
+ Hits 1548 1551 +3
- Misses 1338 1339 +1
+ Partials 127 126 -1
☔ View full report in Codecov by Sentry. |
Pwuts
previously requested changes
Apr 26, 2023
ntindle
approved these changes
Apr 27, 2023
collijk
approved these changes
Apr 27, 2023
collijk
dismissed
Pwuts’s stale review
All feedback from the review has addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Many times auto gpt will try to download or append to files in a directory that doesn't exist, this will cause an error that it then tries to correct, sometimes unsuccessfully.
Related issue: #3249
Changes
I added logic to check if the directory exists and if not create it. I used the same code already being used for
write_to_fileand added it to theappend_to_fileanddownload_fileoperations.Documentation
No documentation.
Test Plan
I had auto gpt download and append to files.
PR Quality Checklist
I didn't add any tests because I couldn't find out where or how to add them as I found other file operations didn't have tests.