Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock openai in test agent manager #3285

Merged

Conversation

waynehamadi
Copy link
Contributor

@waynehamadi waynehamadi commented Apr 26, 2023

Background

not much value calling openai in these unit tests.

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@waynehamadi waynehamadi changed the title mock openai in test image gen mock openai in test agent manager Apr 26, 2023
@waynehamadi
Copy link
Contributor Author

@collijk

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -7.23 ⚠️

Comparison is base (749b1bb) 50.73% compared to head (47126bf) 43.50%.

❗ Current head 47126bf differs from pull request most recent head 25c29be. Consider uploading reports for the commit 25c29be to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3285      +/-   ##
==========================================
- Coverage   50.73%   43.50%   -7.23%     
==========================================
  Files          65       65              
  Lines        2935     2935              
  Branches      493      493              
==========================================
- Hits         1489     1277     -212     
- Misses       1326     1588     +262     
+ Partials      120       70      -50     

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Apr 26, 2023 1:04pm

@waynehamadi waynehamadi mentioned this pull request Apr 26, 2023
5 tasks
@collijk collijk merged commit 4241fbb into Significant-Gravitas:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants