Skip to content

use pytest-recording with VCR #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2023
Merged

use pytest-recording with VCR #3283

merged 2 commits into from
Apr 26, 2023

Conversation

waynehamadi
Copy link
Contributor

Background

use pytest-recording

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@codecov
Copy link

codecov bot commented Apr 26, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -7.33 ⚠️

Comparison is base (0ff471a) 50.76% compared to head (be7aff6) 43.44%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3283      +/-   ##
==========================================
- Coverage   50.76%   43.44%   -7.33%     
==========================================
  Files          65       65              
  Lines        2935     2935              
  Branches      492      492              
==========================================
- Hits         1490     1275     -215     
- Misses       1326     1590     +264     
+ Partials      119       70      -49

see 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynehamadi
Copy link
Contributor Author

@Pwuts @collijk

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/pytest-recording branch from f96125a to e92ffcf Compare April 26, 2023 13:04
@vercel
Copy link

vercel bot commented Apr 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 4:49pm

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi mentioned this pull request Apr 26, 2023
Closed
5 tasks
collijk
collijk reviewed Apr 26, 2023
View reviewed changes
@collijk
Copy link
Contributor

collijk commented Apr 26, 2023

I would put your vcr_config feature and the functions it calls in tests/integration/conftest.py. pytest sources those things hierarchically, and I think we want to limit testing utilities and the like to all live in conftest.py files if we can.

collijk
collijk suggested changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@collijk collijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things, but this otherwise looks quite good.

@waynehamadi waynehamadi force-pushed the feature/pytest-recording branch from e92ffcf to da1a61b Compare April 26, 2023 16:41
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

1 similar comment
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@vercel vercel bot temporarily deployed to Preview April 26, 2023 16:42 Inactive
@waynehamadi waynehamadi force-pushed the feature/pytest-recording branch from 53271ec to feef081 Compare April 26, 2023 16:47
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@vercel vercel bot temporarily deployed to Preview April 26, 2023 16:49 Inactive
@waynehamadi
Copy link
Contributor Author

Changes applied

@collijk collijk merged commit a6355a6 into Significant-Gravitas:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@collijk collijk collijk approved these changes

Assignees
No one assigned
Labels
size/xl testing
Projects
AutoGPT development kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waynehamadi @collijk @ntindle