-
Notifications
You must be signed in to change notification settings - Fork 44.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have api manager use singleton pattern #3269
Merged
ntindle
merged 5 commits into
Significant-Gravitas:master
from
collijk:bugfix/api-manager-use-singleton-pattern
Apr 26, 2023
Merged
Have api manager use singleton pattern #3269
ntindle
merged 5 commits into
Significant-Gravitas:master
from
collijk:bugfix/api-manager-use-singleton-pattern
Apr 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3269 +/- ##
==========================================
- Coverage 50.73% 43.44% -7.30%
==========================================
Files 65 65
Lines 2935 2935
Branches 493 492 -1
==========================================
- Hits 1489 1275 -214
- Misses 1326 1590 +264
+ Partials 120 70 -50
☔ View full report in Codecov by Sentry. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
ntindle
approved these changes
Apr 26, 2023
Wait why does the debug flag exist at all? Can’t we pass —debug and logger handle it |
ntindle
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The api manager came in a little hot and one of the things we missed was it's inconsistent method of being used as a singleton. The class was instantiated at the module level and then the instance was imported in other modules. This PR revises the singleton implementation to use tools standard in the package.
Changes
Documentation
N/A
Test Plan
Small CI updates, but otherwise this class is already covered.
PR Quality Checklist