Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(docs) requirements link in installation guide #3264

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

apurvsibal
Copy link
Contributor

@apurvsibal apurvsibal commented Apr 25, 2023

I want to say thank you for the incredible work the AutoGPT library creators have done. I encountered a broken link while reviewing the documentation for Auto-GPT installation at https://significant-gravitas.github.io/Auto-GPT/installation/. Upon further investigation, I can confirm that the issue is caused by a relative URL that leads to an incorrect destination, specifically https://significant-gravitas.github.io/Auto-GPT/README.md#-requirements.

To address this issue, I have taken the necessary steps to modify the requirements URL from a relative to an absolute link, in order to ensure that it points to the correct location. I considered adding the complete link https://github.com/Significant-Gravitas/Auto-GPT/blob/master/README.md#-requirements but considering the sustainability and best code practices added https://github.com/Significant-Gravitas/Auto-GPT#-requirements.

@Significant-Gravitas - Please let me know if I can improve or if I have missed any community guidelines in making the edit? Thank you again for your hard work and dedication to the open source community.

Background

While going through the documentation for installation, I was taken to a 404 link when looking for requirements in the "General Setup".

Changes

The change makes sure the link is working in the repository and in the documentation. Therefore the requirements link has been changed from relative to absolute.

Documentation

The change is reflected in the installation documentation.

Test Plan

You can check the link in https://significant-gravitas.github.io/Auto-GPT/installation/ in "General Setup" point 1.

PR Quality Checklist

  • [ Yes] My pull request is atomic and focuses on a single change.
  • [Yes ] I have thoroughly tested my changes with multiple different prompts.
  • [Yes ] I have considered potential risks and mitigations for my changes.
  • [Yes ] I have documented my changes clearly and comprehensively.
  • [Yes ] I have not snuck in any "extra" small tweaks changes

I want to say thank you for the incredible work the AutoGPT library creators have done. I encountered a broken link while reviewing the documentation for Auto-GPT installation at https://significant-gravitas.github.io/Auto-GPT/installation/. Upon further investigation, I can confirm that the issue is caused by a relative URL that leads to an incorrect destination, specifically https://significant-gravitas.github.io/Auto-GPT/README.md#-requirements.

To address this issue, I have taken the necessary steps to modify the requirements URL from a relative to an absolute link, in order to ensure that it points to the correct location.
@Pwuts
Copy link
Member

Pwuts commented Apr 26, 2023

That's a lot of explanation for such a small change. Thanks :)

@Pwuts Pwuts changed the title Update the requirements URL Fix(docs) requirements link in installation guide Apr 26, 2023
@Pwuts Pwuts merged commit 749b1bb into Significant-Gravitas:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants