-
Notifications
You must be signed in to change notification settings - Fork 44.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indirection layer to entry point #3152
Add indirection layer to entry point #3152
Conversation
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3152 +/- ##
==========================================
- Coverage 49.70% 41.66% -8.04%
==========================================
Files 64 65 +1
Lines 3026 3029 +3
Branches 507 507
==========================================
- Hits 1504 1262 -242
- Misses 1402 1702 +300
+ Partials 120 65 -55
... and 14 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
bbe052a
to
5ae06b3
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
5ae06b3
to
45f2513
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Background
This is the first PR on the path to build a comprehensive error log that users can include it in their github issues for faster debugging. It simply adds a layer of indirection between the cli and the application main. We can then wrap the main invocation easily in a try except block or similar to extract information about the error.
Changes
Add a layer of indirection between the cli and the application start
Documentation
Module docstring, but otherwise no code changes to document.
Test Plan
This PR changes no logic.
PR Quality Checklist