Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indirection layer to entry point #3152

Conversation

collijk
Copy link
Contributor

@collijk collijk commented Apr 24, 2023

Background

This is the first PR on the path to build a comprehensive error log that users can include it in their github issues for faster debugging. It simply adds a layer of indirection between the cli and the application main. We can then wrap the main invocation easily in a try except block or similar to extract information about the error.

Changes

Add a layer of indirection between the cli and the application start

Documentation

Module docstring, but otherwise no code changes to document.

Test Plan

This PR changes no logic.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -8.04 ⚠️

Comparison is base (06e81b7) 49.70% compared to head (4a20616) 41.66%.

❗ Current head 4a20616 differs from pull request most recent head 128d83a. Consider uploading reports for the commit 128d83a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3152      +/-   ##
==========================================
- Coverage   49.70%   41.66%   -8.04%     
==========================================
  Files          64       65       +1     
  Lines        3026     3029       +3     
  Branches      507      507              
==========================================
- Hits         1504     1262     -242     
- Misses       1402     1702     +300     
+ Partials      120       65      -55     
Impacted Files Coverage Δ
autogpt/cli.py 0.00% <0.00%> (ø)
autogpt/main.py 0.00% <0.00%> (ø)

... and 14 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@collijk collijk force-pushed the refactor/add-indirection-layer-around-entry-point branch from bbe052a to 5ae06b3 Compare April 24, 2023 19:10
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@collijk collijk closed this Apr 24, 2023
@collijk collijk force-pushed the refactor/add-indirection-layer-around-entry-point branch from 5ae06b3 to 45f2513 Compare April 24, 2023 19:11
@github-actions github-actions bot added size/xs and removed size/xl labels Apr 24, 2023
@collijk collijk reopened this Apr 24, 2023
@github-actions github-actions bot added size/xl and removed size/xs labels Apr 24, 2023
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@collijk collijk merged commit 8bf4eb7 into Significant-Gravitas:master Apr 24, 2023
@collijk collijk deleted the refactor/add-indirection-layer-around-entry-point branch April 24, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants