Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Milvus module config import #3036

Merged
merged 2 commits into from
Apr 23, 2023
Merged

Fix Milvus module config import #3036

merged 2 commits into from
Apr 23, 2023

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Apr 23, 2023

Background

#2127 (comment)

Changes

fix module path.

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@chyezh chyezh marked this pull request as ready for review April 23, 2023 16:28
Pwuts
Pwuts previously approved these changes Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -6.38 ⚠️

Comparison is base (cac1ea2) 45.81% compared to head (d6148ce) 39.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3036      +/-   ##
==========================================
- Coverage   45.81%   39.44%   -6.38%     
==========================================
  Files          60       60              
  Lines        2918     2918              
  Branches      480      480              
==========================================
- Hits         1337     1151     -186     
- Misses       1472     1692     +220     
+ Partials      109       75      -34     
Impacted Files Coverage Δ
autogpt/memory/milvus.py 3.44% <0.00%> (ø)

... and 16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pwuts Pwuts changed the title fix module error in milvus Fix Milvus module config import Apr 23, 2023
@Pwuts Pwuts merged commit da48f9c into Significant-Gravitas:master Apr 23, 2023
@Pwuts Pwuts added the bug Something isn't working label Apr 23, 2023
@chyezh chyezh deleted the module_import_error_fix branch April 24, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants