Chat plugin capability #2929
Merged
Chat plugin capability #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to change enumerate to make the plugin work. |
BillSchumacher
previously requested changes
Apr 25, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
I have no concerns about the config usage after the update at @BillSchumacher 's request. Will leave it to you guys to work through any remaining concerns. |
|
Requested Changes are done! :) |
richbeales
approved these changes
Apr 26, 2023
ntindle
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
As I am currently building the telegram chat plugin, the plugin capabilities for logs, userinput etc were missing.
Changes
anywhere the user gets feedback and get asked for input, the input is sent to the according plugin method
Documentation
can_handle_report and can_handle_user_input needed in plugin init.py
handle_input(str) is a sync method that is supposed to work similar to the "input()" method, only that it can be used for example for asking the User a question and waiting for the answer.
report(str) just sends the user a message like a log or in my case with telegram chat it will just forward all messages that would normally only be visible in the terminal.
To enable, set CHAT_MESSAGES_ENABLED=True in your .env file
Test Plan
I will finish my telegram chat plugin and then set the missing ticks.
Feel free to also test then, as this is supposed to be available to every type of plugin that needs those methods.
PR Quality Checklist