Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic prompting #2896

Merged
merged 40 commits into from
Apr 23, 2023
Merged

Automatic prompting #2896

merged 40 commits into from
Apr 23, 2023

Conversation

Torantulino
Copy link
Member

@Torantulino Torantulino commented Apr 22, 2023

Background

Prompt engineering, although in English, is a bad user experience that takes skill and practice.

This addition removes the need for laborious prompt engineering from Auto-GPT, by creating a system so easy that anybody can use it effectively.

Instead of having to manually enter the ai_config information, the user can simply now type something as simple as "Make pong", and a suitable ai_config will be automatically generated.

image

Changes

  • Adds automatic ai_config generation as the default user flow.
  • Relegates manual ai_config creation to an optional "manual mode"
  • Adds tests to cover automatic and manual ai_config creation
  • Displays AI details to user upon creation.

Documentation

Docstrings and comments throughout

Test Plan

I have implemented unit tests to cover the new and existing functions in the setup.py file.

The prompt system prompt will likely need to be further improved going forward so that it leans on AutoGPT's skill-set.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@richbeales
Copy link
Contributor

linting fail

Copy link
Member

@ntindle ntindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a note to news for this

@ntindle
Copy link
Member

ntindle commented Apr 22, 2023

And fix the linting

Copy link
Member

@ntindle ntindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also you mayyyyy have infinite tests so take a look at that

@richbeales richbeales added enhancement New feature or request AI efficacy labels Apr 22, 2023
@github-actions github-actions bot added size/xl and removed size/l labels Apr 22, 2023
@Torantulino
Copy link
Member Author

CI Tests should be fixed in #2904

Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely going to be good for UX. :)

autogpt/setup.py Outdated Show resolved Hide resolved
@Torantulino
Copy link
Member Author

Would be great to see some tests and prompt tweaks on the system prompt here.

It's not perfect yet, as you can see in the example it includes steps that don't play to the strengths of an LLM.

waynehamadi
waynehamadi previously approved these changes Apr 22, 2023
Signed-off-by: Merwane Hamadi <[email protected]>
@Pwuts
Copy link
Member

Pwuts commented Apr 22, 2023

Why are the unit tests getting canceled?

Merwane Hamadi and others added 3 commits April 22, 2023 09:52
Signed-off-by: Merwane Hamadi <[email protected]>
Enable support for loading multiple plugins per zip file
@richbeales richbeales requested a review from ntindle April 22, 2023 17:52
richbeales
richbeales previously approved these changes Apr 22, 2023
richbeales and others added 6 commits April 22, 2023 19:28
Plugins: debug line always printed in plugin load
Signed-off-by: Merwane Hamadi <[email protected]>
Signed-off-by: Merwane Hamadi <[email protected]>
…tests

add decorator to tests so it's skipped if api key required but not present in the environment
@ntindle
Copy link
Member

ntindle commented Apr 22, 2023

@richbeales in tests/utils.py theres a new decorator to require an API key to exist before running the test that uses it. Can you add it to the tests as required here? You can see it used in https://github.com/Significant-Gravitas/Auto-GPT/blob/master/tests/integration/goal_oriented/test_write_file.py

@Torantulino Torantulino dismissed stale reviews from richbeales and waynehamadi via 7bd4a0d April 22, 2023 23:26
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 22, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 23, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

ntindle
ntindle previously approved these changes Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch coverage: 76.47% and project coverage change: +0.99 🎉

Comparison is base (2b5852f) 45.09% compared to head (6e4ae68) 46.08%.

❗ Current head 6e4ae68 differs from pull request most recent head 73349c2. Consider uploading reports for the commit 73349c2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2896      +/-   ##
==========================================
+ Coverage   45.09%   46.08%   +0.99%     
==========================================
  Files          60       60              
  Lines        2856     2890      +34     
  Branches      472      476       +4     
==========================================
+ Hits         1288     1332      +44     
+ Misses       1463     1448      -15     
- Partials      105      110       +5     
Impacted Files Coverage Δ
autogpt/prompts/prompt.py 58.33% <0.00%> (-8.34%) ⬇️
autogpt/setup.py 82.45% <92.85%> (+65.21%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@richbeales richbeales merged commit f462674 into master Apr 23, 2023
@richbeales richbeales deleted the automatic-prompting branch April 23, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants