Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin command arg ordering issue. #2631

Merged

Conversation

BillSchumacher
Copy link
Contributor

It's possible that the plugin args are not in the correct order, use ** instead.

Background

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

richbeales
richbeales previously approved these changes Apr 20, 2023
evahteev
evahteev previously approved these changes Apr 20, 2023
@richbeales richbeales dismissed stale reviews from evahteev and themself via ea26988 April 22, 2023 15:58
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@99eac6c). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2631   +/-   ##
=========================================
  Coverage          ?   36.25%           
=========================================
  Files             ?       60           
  Lines             ?     2849           
  Branches          ?      471           
=========================================
  Hits              ?     1033           
  Misses            ?     1754           
  Partials          ?       62           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@richbeales richbeales merged commit f04755b into Significant-Gravitas:master Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants