Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple resumption of tasks on startup from long-term memory #2602

Conversation

jondwillis
Copy link

@jondwillis jondwillis commented Apr 19, 2023

Background

Every new run of auto-gpt results in an empty memory line "This reminds you of these events from your past:\n\n\n" In order to better resume goals based on previous long term memories, I was having to do a lot of error-prone goal-prompt engineering. This makes the agent more self-aware if it has long-term memory, but also less deterministic.

Related pull-request: #2530
This is an alternative approach to the above PR. If one like that or similar is merged, this can be closed.

Changes

Agents will now have relevant memories based on their agent settings file prompt and user input on startup.

Documentation

Inline in the code.

Test Plan

Existing tests pass.

Risks

  • If Auto-GPT has done something Mal-adaptive, or the ai settings files change, and incorrectly recalls memory from previous runs, it could "poison" present and future runs. It is not always easy / not all users know how to clear memory.
  • This may break certain existing use-cases or change prompt output unexpectedly for existing users.

Risk Mitigation

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 4:43pm

@vercel vercel bot temporarily deployed to Preview April 26, 2023 16:43 Inactive
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -7.37 ⚠️

Comparison is base (0ff471a) 50.76% compared to head (4a00898) 43.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2602      +/-   ##
==========================================
- Coverage   50.76%   43.39%   -7.37%     
==========================================
  Files          65       65              
  Lines        2935     2938       +3     
  Branches      492      493       +1     
==========================================
- Hits         1490     1275     -215     
- Misses       1326     1593     +267     
+ Partials      119       70      -49     
Impacted Files Coverage Δ
autogpt/chat.py 21.95% <0.00%> (-42.61%) ⬇️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 27, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@ntindle
Copy link
Member

ntindle commented Apr 27, 2023

Can you cover this with a bit of testing

@p-i-
Copy link
Contributor

p-i- commented May 5, 2023

This is a mass message from the AutoGPT core team.
Our apologies for the ongoing delay in processing PRs.
This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to:
https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

@Pwuts Pwuts added the fridge Items that can't be processed right now but can be of use or inspiration later label Jun 14, 2023
@Pwuts
Copy link
Member

Pwuts commented Jun 14, 2023

Thanks for submitting! This is an interesting and seemingly useful addition. At the moment the long-term memory is not in use: it was disabled and mostly removed/reworked (#4208) for lack of performance. I have labeled this with fridge so we can find it back and process it when the dust settles.

@Pwuts Pwuts closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI efficacy conflicts Automatically applied to PRs with merge conflicts fridge Items that can't be processed right now but can be of use or inspiration later function: memory size/m
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants