Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure git operations occur in the working directory #2020

Merged
merged 1 commit into from
Apr 16, 2023
Merged

ensure git operations occur in the working directory #2020

merged 1 commit into from
Apr 16, 2023

Conversation

ccheney
Copy link
Contributor

@ccheney ccheney commented Apr 16, 2023 •
edited
Loading

Background

closes #1971
closes #1734
closes #735

Changes

This change simply wraps the intended clone path with the path_in_workspace helper function to ensure output is sent to the working directory

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

Pwuts
Pwuts approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@p-i- p-i- merged commit 15059c2 into Significant-Gravitas:master Apr 16, 2023
@tannerchiang tannerchiang mentioned this pull request Nov 8, 2023
Open
@jihaui jihaui mentioned this pull request Nov 24, 2023
Open
@hxs9712 hxs9712 mentioned this pull request Dec 1, 2023
Open
@jimjonesbabyfreshout jimjonesbabyfreshout mentioned this pull request Dec 5, 2023
Open
@MyDevops101 MyDevops101 mentioned this pull request Feb 8, 2024
Open
@dewankpant dewankpant mentioned this pull request Feb 10, 2024
Open
@matr1xp matr1xp mentioned this pull request Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-i- p-i- p-i- approved these changes

@Pwuts Pwuts Pwuts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ccheney @p-i- @Pwuts